refactor: Rewrite hostname, jobs and line_break module to use module config #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matchai
reviewed
Oct 8, 2019
There was a problem hiding this comment.
Sorry for the long wait to review. Looks good to me! 👍
Just looks like we're hitting an ownership error during compilation:
https://github.com/starship/starship/pull/462/checks?check_run_id=251463098#step:4:653
heyrict
force-pushed
the
refactor_config_update_module_hostname
branch
from
a5a7d97
to
cbd5562
Compare
heyrict
force-pushed
the
refactor_config_update_module_hostname
branch
from
cbd5562
to
c6cd506
Compare
|
Solved by moving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a batch rewrite of the following modules:
Motivation and Context
Related #383
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: