Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename var AWS_SESSION_EXPIRATION for aws-vault v7+ #4974

Closed

Conversation

bruno
Copy link

@bruno bruno commented Mar 9, 2023

In aws-vault v7.0.0 the authors removed the AWS_SESSION_EXPIRATION env var and recommend the use of AWS_CREDENTIAL_EXPIRATION. This commit just renames the variable name.

Description

A simple rename of the old ENV var that was expected to contain the expiration of the session to the new name.

Motivation and Context

As described in the commit message, aws-vault v7.0.0 no longer sets the variable named AWS_SESSION_EXPIRATION with the details of when the session will expire, so starship wasn't displaying it anymore.

Closes: #4783

I've run the cargo test locally on an Apple Silicon and x86 Linux (Ubuntu 22.04 LTS).

test result: ok. 951 passed; 0 failed; 32 ignored; 0 measured; 0 filtered out; finished in 0.82s

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

In [aws-vault v7.0.0](https://github.com/99designs/aws-vault/releases/tag/v7.0.0) the authors removed the `AWS_SESSION_EXPIRATION` env var and recommend the use of `AWS_CREDENTIAL_EXPIRATION`. This commit just renames the variable name.
Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding support for the other environment variable is good, and it sounds like it should have a higher priority than the current value, but please keep the support of it for the time being. This new aws-vault release has only been out for 3 days, and other tools could using the variable.
Please also avoid making any changes to the non-English documentation.

@bruno
Copy link
Author

bruno commented Mar 12, 2023

Thanks for the feedback @davidkna. All good suggestions, sorry about the changes to the non-English docs. I will try to get to this in the near future ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support aws-cli's AWS_CREDENTIAL_EXPIRATION envar
2 participants