Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hostname): add detect_env_vars as option #5196

Merged
merged 9 commits into from Sep 16, 2023
Merged

feat(hostname): add detect_env_vars as option #5196

merged 9 commits into from Sep 16, 2023

Commits on Aug 30, 2023

  1. Added hostname.detect_env_vars 

    based on the newly added context::detect_env_vars

- extended context::detect_env_vars to check for negated environment
  variables as well, analogous to the other detect modules
- made hostname.detect_env_vars only active if ssh_only is set to false
  for backwards compatibility

Co-authored-by: Dominik Sander <dsander@users.noreply.github.com>
    @mickimnet @dsander
    mickimnet and dsander committed Aug 30, 2023
    Copy the full SHA
    b637e43 View commit details
    Browse the repository at this point in the history

  2. added clippy recommendations, removed unneeded comments

    @mickimnet
    mickimnet committed Aug 30, 2023
    Copy the full SHA
    66f0e8d View commit details
    Browse the repository at this point in the history

  3. Added new logic (suggested in starship#5196 (comment)) 

    The new `detect_env_vars` now requires either SSH_ONLY to be false or the
environment variable SSH_CONNECTION to be set, so that is will be used
    @mickimnet
    mickimnet committed Aug 30, 2023
    Copy the full SHA
    9ca1f69 View commit details
    Browse the repository at this point in the history

  4. Fixed typo

    @mickimnet
    mickimnet committed Aug 30, 2023
    Copy the full SHA
    3431c0b View commit details
    Browse the repository at this point in the history

  5. Refactored the detect_env_vars function for early returns and better … 

    …readability
    @mickimnet
    mickimnet committed Aug 30, 2023
    Copy the full SHA
    e66508b View commit details
    Browse the repository at this point in the history

  6. Change boolean logic for better readability 

    Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
    @mickimnet @davidkna
    mickimnet and davidkna committed Aug 30, 2023
    Copy the full SHA
    597845a View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review to detect_env_vars method. 

    Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
    @mickimnet @davidkna
    mickimnet and davidkna committed Aug 30, 2023
    Copy the full SHA
    18a4225 View commit details
    Browse the repository at this point in the history

  8. Fixed bracket error & updated comments 

    - fixed bracket error in hostname.rs, after changes
- updated comments for context.rs, for the suggested changes
    @mickimnet
    mickimnet committed Aug 30, 2023
    Copy the full SHA
    6bccee2 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Removed obsolete warning from docs/config/README.md 

    Co-authored-by: David Knaack <davidkna@users.noreply.github.com>
    @mickimnet @davidkna
    mickimnet and davidkna committed Sep 1, 2023
    Copy the full SHA
    2790197 View commit details
    Browse the repository at this point in the history