feat: switch windows MSI installers to wix v5 #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves MSI installer packaging from
cargo-wix(wix v3) to plain wix v5. Unlike the prior version, wix v5 supports aarch64 without resorting to pre-release versions, the XML-manifest is somewhat cleaner, and we no longer need to buildcargo-wixfrom source. On the other hand, wix v4 is not preinstalled on GHA runners like v3 is. I also replaced the BMP-files with PNGs, since those seem to be supported as well now.Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: