Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: R lang packages version, remove .Rprofile from rlang detection #5588

Merged
merged 7 commits into from Nov 29, 2023
Merged

feat: R lang packages version, remove .Rprofile from rlang detection #5588

merged 7 commits into from Nov 29, 2023

Conversation

jangorecki
Copy link
Contributor

@jangorecki jangorecki commented Nov 20, 2023

Description

Motivation and Context

Closes #5586, closes #2817, closes #5590

How Has This Been Tested?

Have not been tested, cargo test getting stuck for many minutes with

test modules::git_commit::tests::test_latest_tag_shown_with_tag_enabled has been running for over 60 seconds
test modules::git_commit::tests::test_latest_tag_shown_with_tag_enabled_lightweight has been running for over 60 seconds

submitting here so at least CI can test it.

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@jangorecki
Copy link
Contributor Author

ready to review/merge

@andytom andytom merged commit 5267c46 into starship:master Nov 29, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rlang project detection is not working rlang improvements $HOME/.Rprofile should be ignored
3 participants