Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor package to handle package version panic #57

Merged
merged 5 commits into from May 16, 2019
Merged

Refactor package to handle package version panic #57

merged 5 commits into from May 16, 2019

Conversation

matchai
Copy link
Member

@matchai matchai commented May 16, 2019

Description

  • Refactor package module
    • Handle when no package version is available
  • Add unit tests for package version

Motivation and Context

Closes #54

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@matchai matchai requested a review from a team May 16, 2019 00:15
jletey
jletey approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@jletey jletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... as always, your code looks a lot better than mine 🤩

@matchai matchai merged commit 876e7d3 into master May 16, 2019
@matchai matchai deleted the fix-no-version-panic branch May 16, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jletey jletey jletey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prompt panics in the root directory of a Rust project without a package.version
2 participants
@matchai @jletey