Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bash): improve integration with bash-preexec #5734

Merged
merged 1 commit into from Feb 4, 2024

Conversation

davidkna
Copy link
Member

Description

  1. For bash-preexec detection, a check for the official bash_preexec_imported variable in addition to the private __bp_imported for prior versions (see Library Authors documentation can still lead to issues rcaloras/bash-preexec#146 and Doesn't work with bash in login mode #5686) I also removed the check for the explicit value defined since that matches the official sample check more strongly.
  2. Always use BP_PIPESTATUS if its length is greater than 0, because the value of PIPESTATUS could be unpredictable (feat(bash): Support right prompt and transience #4902 (comment)).

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna merged commit 2aa711c into starship:master Feb 4, 2024
17 checks passed
@davidkna davidkna deleted the bp-fixes branch February 4, 2024 15:02
@davidkna
Copy link
Member Author

davidkna commented Feb 4, 2024

Thanks for the review @andytom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants