ci: add preliminary windows codesigning via signpath #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
force-pushed
the
signpath
branch
2 times, most recently
from
ee78ac1
to
9884355
Compare
davidkna
force-pushed
the
signpath
branch
2 times, most recently
from
db6ad8f
to
5e929c6
Compare
matchai
approved these changes
May 3, 2024
|
Thanks for the reviews @matchai! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds windows code signing via signpath on a preliminary basis to test the integration until we are issued a release certificate.
To sign the executables and installers at the same time, I also modified the workflows to put both in the same directory.
Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: