Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): don't trigger if scan config is set but env vars are not #5979

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

davidkna
Copy link
Member

Description

Because both the scan config for files and the env var config are optional, additional handling is needed.
This PR changes for the checks for the return None to prevent a default-empty `detect_env_vars from always preventing the module from being ignore.

Motivation and Context

Closes #5978

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@jankatins
Copy link
Contributor

LGTM

@davidkna davidkna merged commit 8c75822 into starship:master Jun 9, 2024
17 checks passed
@davidkna davidkna deleted the fix-k8s-env branch June 9, 2024 07:55
@davidkna
Copy link
Member Author

davidkna commented Jun 9, 2024

Thanks for the reviews @jankatins and @andytom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes module triggers without env vars
3 participants