Refactor integration tests #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 30, 2019 19:23
- Replace the use of Segments directly with plain colored text to check stdout - Create temp files in /tmp instead of in $TEMPDIR to ensure we have the necessary file permissions
matchai
added
the
🔧 maintenance
added 14 commits
May 30, 2019 22:38
Building multiple test binaries caused the false positives about dead code. It also makes for much slower testing.
Because the architecture on local machines might not match that on Azure, the pull step will be optional.
|
By updating tests to use the binary directly, I inadvertently made coverage instrumentation unable to catch our test runs. 🤦♂ |
added 2 commits
May 31, 2019 17:19
The decision right now comes down between more thorough end-to-end testing or having code coverage tooling. For the time being, I think the confidence provided by e2e tests outweighs the value of having code coverage. This may change if we find a reliable mocking solution that allows most of our tests to be integration tests.
Snuggle
approved these changes
May 31, 2019
| #[test] | ||
| #[ignore] | ||
| fn git_repo_root() -> io::Result<()> { | ||
| // TODO: Investigate why git repo related tests fail when the tempdir is within /tmp/... |
There was a problem hiding this comment.
I've noticed this with random software so often. If I put a file in /tmp, it just fails in some unexpected way. It can't be a permissions issue, I'm really not sure what causes this weirdness.
Sometimes I've stored images in /tmp and been unable to select them in applications. I'd love an explanation. 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't be scared off by the number of files changed. I simply moved the test files, and GitHub doesn't play nicely. 😅
starship promptwill print the full promptstarship module <MODULE_NAME>will print a specific modulee.g.
starship module python--pathflag to print the prompt or modules without being in a specific directory--statusflag to provide the status of the last command, instead of requiring it as an argumentusernamemoduletests/testsuiteto allow for a single binary to be builtusernameRemoving Codecov + tarpaulin
The decision was split between more thorough end-to-end testing or having code coverage tooling. For the time being, I think the confidence provided by e2e tests outweighs the value of having code coverage.
This may change if we find a reliable mocking solution that allows most of our tests to be integration tests.
Motivation and Context
Adding integration tests was difficult. Hopefully, this will be easier to maintain.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: