Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摑 路 Fix fisher command in README. #84

Merged
merged 1 commit into from Jun 18, 2019
Merged

馃摑 路 Fix fisher command in README. #84

merged 1 commit into from Jun 18, 2019

Conversation

Snuggle
Copy link
Member

@Snuggle Snuggle commented Jun 17, 2019

Description

fisher $PWD is not a valid command. fisher add $PWD can be used to install.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change (non-breaking change to documentation)

Screenshots (if appropriate):

image

Checklist:

  • I have updated the documentation accordingly.

@Snuggle Snuggle added the 馃敡 maintenance Maintenance tasks, usually to do with documentation, CI, or project structure. label Jun 17, 2019
@Snuggle Snuggle self-assigned this Jun 17, 2019
@Snuggle Snuggle requested a review from a team June 17, 2019 18:22
jletey
jletey approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@jletey jletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't use fisher, but this LGTM @Snuggle!

@matchai matchai merged commit 588fa19 into starship:master Jun 18, 2019
@Snuggle Snuggle deleted the LetsGoFishing branch June 18, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jletey jletey jletey approved these changes

Assignees

@Snuggle Snuggle

Labels
馃敡 maintenance Maintenance tasks, usually to do with documentation, CI, or project structure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snuggle @jletey @matchai