Propagate errors on module resolution if required module has a bad re…

…quire

packages/starspot-core/src/resolver.ts

@@ -92,7 +92,15 @@ export default class Resolver {
 
         mod = require(absolutePath);
       } catch (e) {
-        if (e.code === "MODULE_NOT_FOUND") { continue; }
+        if (e.code === "MODULE_NOT_FOUND") {
+          // MODULE_NOT_FOUND can be thrown if the file we required exists but required a non-existent module itself
+          // In that case, we want to throw an error so the user knows to fix their module
+          try {
+            require.resolve(absolutePath);
+          } catch (e) {
+            continue;
+          }
+        }
 
         this.ui.veryVerbose({
           name: "resolver-requiring-error",
@@ -167,4 +175,4 @@ export default class Resolver {
 
 function stripFileExtension(path: string) {
   return path.split(".").slice(0, -1).join(".");
-}
+}

packages/starspot-core/test/fixtures/resolver/app/controllers/bad-require.ts

@@ -0,0 +1,2 @@
+
+require("ugh-tom-dale");

packages/starspot-core/test/resolver-test.ts

@@ -74,4 +74,13 @@ describe("Resolver", function() {
     }
   });
 
-});
+  it("throws if a module is found with an invalid import", function() {
+    let resolver = new Resolver({
+      rootPath: fixture("resolver")
+    });
+
+    expect(function() {
+      resolver.resolve(["controller", "bad-require"]);
+    }).to.throw();
+  });
+});