Fix for ROS Noetic #371
Open
Fix for ROS Noetic #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
reviewed
Jun 13, 2024
| @@ -46,7 +46,7 @@ def parse_filename(filestr): | |||
| pkgname = ret.group(1) | |||
| #packagepath = commands.getoutput('rospack find %s'%(pkgname)) | |||
| packagepath = subprocess.check_output(['rospack', 'find', pkgname]) | |||
| packagepath = packagepath.rstrip('\n') | |||
| packagepath = packagepath.decode().rstrip('\n') | |||
There was a problem hiding this comment.
confirmed this works on python2 too
There was a problem hiding this comment.
This script failed to run in melodic. I'll make it compatible with both ros version
k-okada
reviewed
Jun 13, 2024
choreonoid_noetic.patch
Outdated
| - <depend>python</depend> | ||
| - <depend>python-numpy</depend> | ||
| + <!-- <depend>python</depend> --> | ||
| + <!-- <depend>python-numpy</depend> --> |
There was a problem hiding this comment.
|
@kirohy are related to Noetic support? |
|
No. Noetic patch is based on https://github.com/start-jsk/rtmros_choreonoid/blob/master/choreonoid.patch, and only python options are changed from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
choreonoid_noetic.patchfor building choreonoid-1.7 in NoeticThese changes will enable to build and run choreonoid samples in
hrpsys_choreonoid_tutorials/launch.