Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hrpsys_ros_bridge_tutorials] publish emergency_mode from EmergencyStopper rtc #763

Merged
merged 1 commit into from
Jul 3, 2015

Conversation

mmurooka
Copy link
Member

@mmurooka mmurooka commented Jul 3, 2015

Please merge after fkanehiro/hrpsys-base#706 is merged.

Current emergency_mode is published as topic /emergency_mode.
0 -> release mode. 1 -> stop_mode.

@@ -102,6 +102,7 @@
<rtconnect from="DataLoggerServiceROSBridge.rtc:DataLoggerService" to="log.rtc:DataLoggerService" subscription_type="new"/>
<rtconnect from="SequencePlayerServiceROSBridge.rtc:SequencePlayerService" to="seq.rtc:SequencePlayerService" subscription_type="new"/>
<rtconnect from="ForwardKinematicsServiceROSBridge.rtc:ForwardKinematicsService" to="fk.rtc:ForwardKinematicsService" subscription_type="new"/>
<rtconnect from="es.rtc:emergencyMode" to="HrpsysSeqStateROSBridge0.rtc:emergencyMode" subscription_type="new"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this line into the region inside <group if="$(arg USE_EMERGENCYSTOPPER)" >?
Currently, this code does not work in Stable rtc environments because rtconnect cannot find es.rtc.
In that case, we use flags like USE_EMERGENCYSTOPPER.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Moved that line.

snozawa added a commit that referenced this pull request Jul 3, 2015
[hrpsys_ros_bridge_tutorials] publish emergency_mode from EmergencyStopper rtc
@snozawa snozawa merged commit 10b2bbe into start-jsk:master Jul 3, 2015
@mmurooka mmurooka deleted the pub-emergency-mode branch July 3, 2015 13:21
@k-okada
Copy link
Member

k-okada commented Jul 4, 2015

On Fri, Jul 3, 2015 at 1:24 PM, Masaki Murooka notifications@github.com
wrote:

Please merge after fkanehiro/hrpsys-base#706
fkanehiro/hrpsys-base#706 is merged.

please add test so that travis can tell us if it is ready to merge

◉ Kei Okada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants