Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC packages #491

Closed
wants to merge 5 commits into from
Closed

Add RPC packages #491

wants to merge 5 commits into from

Conversation

130s
Copy link
Contributor

@130s 130s commented Mar 24, 2017

Adding RPC (Remote Procedure Call) feature for higher level of robot operations for the Hironx-variant robots (i.e. Hironx, NEXTAGE Open). Being based on tork_rpc, many high level features can be now invoked via ROS Service (and Topic, Action for limited features too). See hironx_rpc_server/doc/index.rst for more info.

This work is sponsored by Keio University Yamaguchi Lab..

Add RPC method (for goInitial as a proto-type).
Add missing generate_messages macro.
[WIP][RPC] Sending GoInitialAction runs, but got the following warning and the command doesn't seem to be executed.
  <quote>Your executeCallback did not set the goal to a terminal status.  This is a bug in your ActionServer implementation. Fix your code!  For now, the ActionServer will set this goal to aborted</quote>.

[WIP][RPC] Add Action feedback and goal.
[rpc] Add goActual, utilizing the srv available from hrpsys_ros_bridge.
[rpc] Minor formatting.
[RPC] Add getCurrentPose.
[rpc] Add checkEncoders.
[rpc] Add getReferencePose.

[RPC][doc] Improvement.
[RPC] Document update. Config for rosdoc.

[rpc][fix] cmake build and test launch file.
[RPC] Add getActualState.
[RPC] Add waitInterpolation.
[RPC] Add waitInterpolationOfGroup.
[RPC] Add setJointAngle*.
[RPC] Add get{Current, Reference}{Position, RPY} methods.
[RPC][test] Sort out launch args.
[RPC] Add goOffPose methods, integrating with goInitial.
[RPC] Add getSensors.

[RPC][sample] Cleanup.
[RPC] Wait for RTM servers to before making connection.
[RPC][test] Fix import error.
[RPC] Fix test launch timing.
[RPC][test] Fix old import.

[RPC] Add Groups.
[RPC] Add getJointAngles.
[RPC] Add getRTCList.
[RPC] Add setTargetPose.
[RPC] Add isServoOn.
[RPC] Add isCalibDone.
[RPC] Add moveHand, setHandJointAngles.
[RPC] Add setEffort.
[RPC] Add loadPattern.
[RPC] Shorter default sleep time upon launching.
[RPC][server] Cleanup.

[RPC] Missing install rule.

[RPC][test] Try passing CORBA args to rpc.py. May better have to be reverted when no effect.

[RPC][test] More specific import.

[RPC][test] cleanup.

[RPC] Fixes

[RPC][test] Start sample node only once during the testsuite.

[RPC][test] Fix wrong self "usage" variable.

[RPC][test] Use a common test module.
[RPC] Fix cmakelist.
[RPC][test] Fix wrong command.
[RPC][test] Fix testcases and sample invocation (after very first Travis CI build (finally tests are being run)).
@130s
Copy link
Contributor Author

130s commented Mar 24, 2017

After having debated myself, I decided to host the entire package suite regarding this feature for HiroNXO at a separate repository from start-jsk/rtmros_hironx. Reasonings:

  • These RPC features are totally optional and will most likely not interest many HiroNXO users.
  • Want to avoid adding another testcases to already-time-taking testsuite. This rtmros_hironx repo is even referred to from the tests at an upstream so we don't want to bother them more.
  • Existing subscribers of this repo won't have to get annoyed by issue reports/PRs for RPC feature.
  • (cons) This RPC feature may get less attention in a separate repo.
  • (cons) Regression may more likely to occur since tests won't run upon PRs to rtmros_hironx --> can be mitigated by utilizing external test hook, e.g. add ROS buildfarm devel testing to the upstream rtmros_hironx.

@130s 130s closed this Mar 24, 2017
@130s 130s mentioned this pull request Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant