[bug]: Factory Reset does not "delete existing data on disk"

[gStart9]

Prerequisites

• I have searched for existing issues that already report this problem.

Server Hardware

x86_64 (Server One)

StartOS Version

0.3.5.1 (nonfree)

Client OS

Linux

Client OS Version

Debian 12

Browser

Firefox

Browser Version

121

Current Behavior

On the Install Type screen, there are two options:

• Re-Install StartOS ["Will preserve existing StartOS data"]
• Factory Reset ["Will delete existing data on disk"]

When selecting Factory Reset, the Data partition is preserved. The result is that anyone who selects "Factory Reset" at install time, after rebooting to the setup wizard, is still presented with the option to "Use existing drive" (See reproduction screenshots below).

Is this intentional?
If so I don't see the reason to offer both "Re-install StartOS" and "Factory Reset"
If not, we have a bug.

Expected Behavior

I am expecting "Factory Reset" to wipe all data (including service data from the user data partition) from the disk. The data is preserved (See screenshots below).

Steps to Reproduce

1. Boot USB installation media (v0351 nonfree in this case) and select the disk:
   

2. Select "Factory Reset" as the install type:
   

3. A warning appears stating "This action will COMPLETELY erase the disk DISK_NAME_":
   

4. The UI indicates success. Click REBOOT:
   

5. Remove the USB installation media and reboot. StartOS setup wizard appears. Choose Recover:
   

6. Under Recover Options, select Use Existing Drive:
   

7. The disk that was supposedly wiped appears as an existing drive able to be used:
   

8. Select the drive and it will restore your old install.

Anything else?

No response

[dr-bonez]

Duplicate of #2162