Fix: Spelling mistake of $date['id']; references to unlock instead of mod; varchar length #59
Conversation
darth3pio
commented
Jun 21, 2023
darth3pio
commented
- $date['id'] should be $data['id']
- Fixed references to unlocks in several comments and strings.
- varchar length in the database shows that name and longname in game_mod is 24 and 48 respectively, updated validator to reflect this.
…sert I suspect, unlike the awards.js table where user input prompts for an id, because the id for game mods is an autoincrement value in the game_mod database table the function isn't pulling down the new value upon insertion and complaining about a null value. This is a possibly temporary fix until I can wrap my head around this specific problem and have ajax handle the table reload as seems to be the way it's handled in other pages within the gamedata module.
|
yay, this looks good now :) Thanks! |
|
By the way, it's difficult for me to find the time to fix some of these things. Really appreciate all your work :) |
|
I figure Docker is a more convenient way to get it all up and running so contributing to this is contributing back into my locally hosted LAN server. |
|
it's nice to know there's still a BF2 community, don't know what happened to bf2statistics.com community when I checked last week :( |
|
Yeah, I noticed that, a bunch of Wilson's repos are gone too so I'm assuming he's maybe packed it in? Life stuff perhaps? Hopefully we'll see him return and if not his legacy will go on. |
darth3pio
changed the title
|
yeah... The BF2Statistics github organization no longer owns the original fork, but the projects are now under ReviveNetwork. Feels like things have moved on. Hopefully there are developers like you that stick around github 😄 |
|
Just enabled the discussions tab on this repo, perhaps it can fill in something for the BF2Statistics community who use ASP v3 😃 |
|
For sure, I'll be sticking with it, a Git like this is perfect for contributing and sharing code and ideas if nothing else. And with modding still active as shown by all of the recent activity over at ModDB the need to have a backend to host it isn't going away. My unrealised dream of course, as teased by several comments from Wilson over recent years is how easy it would allegedly be to get Battlefield 2142 support integrated. That's one of my longterm goals. There's something about that era of Battlefield that has stayed with me. |
|
Didn't know BF2142 could be integrated with this stats system? Perhaps the engines are almost the same? I've owned but didn't play 2142 much, so it's pretty much only BF2 for me 😝 |
|
Wilson bookmarked [imported Google Code repos] a bunch of stuff including (imported Google Code repos), https://github.com/wilson212/bf2142stats_emu, but I assume it was a back of the queue sort of thing. Most of the work would be around the login side of things I suspect. Looking at the game server constants.py the structure looks similar enough that the stats database wouldn't need too much work. |
|
More than anything, I wanna get back into the Star Wars: First Strike mod. That thing was a heck of a lot of fun. |
|
Cool stuff. Good thing the google code repos are automatically imported to github, or a lot of work would have been lost. Perhaps somebody might be bold enough to work on that 😀 Those old games are a heck of fun. My fondest memories are with Counter-Strike, which is still going on strong 😛 |
|
By the way, from your recent testing, does ASP v3 work properly most of the time? I haven't been using ASP v3 so it'll be nice to know whether it really works, and haven't been following the BF2Statistics community in regard to ASP v3 too, so I don't know about the roadmaps / bugs / new features people were requesting. At this point, if it's working, we might be able to cut a release for |
|
Taking a peek at archive.org shows that Wilson was going to release a v4 in January this year but everything went dark, so I'm not sure where he's at. I mostly followed the Github repo as I figured I'd get updates there sooner than I would over at the forums. There's a "ToDo" in the root of ASP but I don't think it's been updated recently so everything that was planned is either on the last post from November or in Wilson's head. As it currently exists, at least in how it's currently promised, it's mostly complete, beyond the ToDo list I'd be looking at modernising for newer PHP versions and all of the breaking issues with removed PHP functions has been fixed, it generates a few deprecated logs still but that probably won't be an issue till we have to move to PHP 8.0 (as highlighted in the post about v4). Maybe padding out the data.sql with additional entries from contants.py. Beyond that I'd love to expand the player activity system so as it shows when they're online and not just if they've played recently. But we've still get a few more increments to go before we reach our own v4 so that's something that can be added later. |
|
Re-reading that post from November also shows that v4 was going to combine some kind of bulletin board with a bf2sclone replacement so maybe the intention was to replace the forums with v4. |
|
Nice information. At least from you described about most fixes already having been done, v3 should work without any major issue. So it should be fine to release As for the planned v4, I assume there's no repo as it is, it was really just a roadmap / idea. It'll be kinda nice to see how ASP could fully replace the forums, in that case the soldier's BF2 in-game account would also be their forum account, with |
|
It looked like something a little more than a roadmap, http://web.archive.org/web/20230209001842/https://bf2statistics.com/threads/update-3-2-incoming-and-php8-support-v4-0.3031/ |
|
Hmm seemed like it was being worked on actively, based on ASP v3 system. Hopefully the site comes back up, it was a great community 😢 if not, somebody to keep this going, we will see. |
