Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Minnano-AV scraper #1539

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

Clasp8775
Copy link
Contributor

  • Automatically convert sizes from Japanese to US
  • Properly add and de-duplicate aliases
  • Set correct name order for StashDB (Last First -> First Last)
  • Search for both name orders to simplify the process
  1. I'm not very proficient in Python so feel free to suggest changes.
  2. Some of the functions (especially converting bra sizes) might be better suited for py_common?

Copy link
Sponsor Collaborator

@Maista6969 Maista6969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great improvement over the XPath scraper! Happy to merge this once it grabs all aliases 👍

scrapers/Minnano-AV/Minnano-AV.py Outdated Show resolved Hide resolved
scrapers/Minnano-AV/Minnano-AV.py Outdated Show resolved Hide resolved
@Clasp8775
Copy link
Contributor Author

Clasp8775 commented Dec 1, 2023

I've tested the alias regex on a few variations but that's the first time seeing that one! I've added a comment with a link to regex101 with the test strings, also putting it here for visibility: https://regex101.com/r/9k2GXw/5

@Maista6969 Maista6969 merged commit 63120b0 into stashapp:master Dec 1, 2023
1 check passed
@Clasp8775 Clasp8775 deleted the minnano-av-improve branch December 1, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants