Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sceneByFragment for PissPlay #998

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DogmaDragon
Copy link
Contributor

Only supports the format where the filename matches the title name in the URL.

Requested here #73 (comment)

Only supports the format where the filename matches the title name in the URL.
@bnkai bnkai added the enhancement New feature or request label May 22, 2022
@bnkai
Copy link
Collaborator

bnkai commented May 22, 2022

Just double checking
For this to work the file must have the exact name of the title.
Do the original files have that form? With the same separators as in the url?
I wouldnt want the majority of the users complaining that we only get 404s

@DogmaDragon
Copy link
Contributor Author

DogmaDragon commented May 23, 2022

E.g. https://pissplay.com/videos/title-of-the-video
The filename has to be title-of-the-video.ext

I don't have an example of the original file structure as I don't have access to the site. Only basing the scraper on the information provided in the request.

I can wait until someone who knows the structure can chime in and update the regex to match that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants