Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markerTagToScene] add all marker tags to scene not just primary #155

Closed
wants to merge 3 commits into from

Conversation

stg-annon
Copy link
Contributor

looks at all marker tags from SceneMarkerUpdateInput and compares them to existing scene tag_ids adds any tags that are missing from scene

looks at all marker tags from `SceneMarkerUpdateInput` and compares them to existing scene `tag_ids` adds any tags that are missing from scene
@stg-annon stg-annon marked this pull request as draft April 7, 2023 00:26
@stg-annon
Copy link
Contributor Author

so js plugins seem to have an issue with arrow functions as well as some other issues I'm unfamiliar with, I could rewrite this in python but I'm not sure that is the ideal solution here so I will draft a PF for it if it is not wanted feel free to close it

bumps version to 2.0 as language change here is somewhat significant
@stg-annon stg-annon marked this pull request as ready for review April 7, 2023 00:34
@xiosensei
Copy link

xiosensei commented Apr 18, 2023

following. it works with this merge request with no issues

@bnkai
Copy link
Collaborator

bnkai commented Apr 24, 2023

@stg-annon sorry for the late review
how does this compare to #152, #154 ?

@stg-annon
Copy link
Contributor Author

stg-annon commented Apr 24, 2023

@bnkai #154 might be preferred as is remains as JS plugin but it lacks the same features which I can introduce to this PR

This PR introduces a library requirement which might not be preferred but its written in such a way that I believe it is more maintainable

@stg-annon stg-annon changed the title add all marker tags to scene not just primary [markerTagToScene] add all marker tags to scene not just primary Oct 8, 2023
@scruffynerf
Copy link
Contributor

scruffynerf commented Oct 20, 2023

@stg-annon still feel the same way? This has sat a while and between this and #154 , and #152. i think one of these go in, or some hybrid approach. Preference?

@stg-annon
Copy link
Contributor Author

this would be easy for me to maintain but I don't love introducing requirements where I don't have to, if stashapp-tools becomes a standard package I'd probably go with this

@stg-annon stg-annon closed this Jan 14, 2024
@stg-annon stg-annon deleted the patch-1 branch January 14, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants