Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritics in Performer Names #41

Merged
merged 4 commits into from Feb 23, 2023

Conversation

DogmaDragon
Copy link
Contributor

@DogmaDragon DogmaDragon commented Feb 21, 2023

Adding a confirmed guideline.
Thread: https://discord.com/channels/559159668438728723/1076296943996780565

I tried to not be very verbose, but you might want it to expand it if it's too concise.

@DogmaDragon DogmaDragon changed the title New confirmed guideline Diacritics in Performer Names Feb 21, 2023
@AdultSun
Copy link
Collaborator

I expanded on the guideline explanation section a little. I think brevity is less important there, especially since we're planning on re-organizing those sections to be stand-alone pages soon.

The biggest change I made is a shift in framing from "diacritics should be used" to "diacritics may be used." Otherwise it sounds too much like any alias with diacritic markings should override all other considerations when picking the primary name, which I don't believe was the intention with this guideline. I clarify that everything listed under "Preferred Primary Names" still applies here while linking to that section.

@DogmaDragon
Copy link
Contributor Author

DogmaDragon commented Feb 21, 2023

Good point on should, not sure why I choose it from the allow mentioned in the Discord thread. My bad.

@AdultSun
Copy link
Collaborator

I think this is ready now. Here's a preview of what it'll look like on the website, I'll share it on Discord for any additional feedback before merging it.

image

@DogmaDragon
Copy link
Contributor Author

I like can be included more than are allowed in the context of this sentence. But I'm good with whatever.

@AdultSun
Copy link
Collaborator

I just felt like "can be included" was too clunky, especially when I use "included" again at the end of the sentence. When you reminded me of how you used "allow" earlier instead I felt that would allow the sentence to flow better. I don't think there's any significant change in meaning there, just personal preference. I'll leave it as-is for now.

It's been a couple days and I haven't gotten any other comments on the current language, so I'll merge this PR.

@AdultSun AdultSun merged commit 81437d6 into stashapp:main Feb 23, 2023
@DogmaDragon DogmaDragon deleted the diacritics-in-performer-names branch January 24, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants