Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Commas in Aliases split the alias on call to ScrapeSinglePerformer #778

Open
BonerFide opened this issue Mar 21, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@BonerFide
Copy link

Describe the bug
Commas are accepted when adding an alias, however when being scraped via Stash (eg ScrapeSinglePerformer) they're not escaped or quoted etc in the return list of aliases, so it will then split an alias with a comma into 2 aliases. This becomes a problem for stash when the comma is what's keeping the aliases distinct.

To Reproduce
Steps to reproduce the behavior:

  1. Add an alias with a comma when creating or modifying a performer
  2. Scrape the performer using scrapeSinglePerformer

{ "data": { "scrapeSinglePerformer": [ { ... "aliases": "abc, abc, def", ... "__typename": "ScrapedPerformer" } ] } }

Expected behavior
Ideally these would be escaped and thus valid everywhere, but it may be simply easier for now to disallow commas in aliases or split them on a comma at the stash-box point of entry.

{ "data": { "scrapeSinglePerformer": [ { ... "aliases": ["abc,abc", "def"], ... "__typename": "ScrapedPerformer" } ] } }

image

@BonerFide BonerFide added the help wanted Extra attention is needed label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant