Add report fingerprint functionality #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Is the idea that the logic for submitting and evaluating reports stays is implemented in the stash tagging interface? |
| unmatch: Boolean | ||
| unmatch: Boolean @deprecated(reason: "Use `vote` with 0 instead") | ||
| "positive for default behaviour, negative to report as invalid, zero to remove vote" | ||
| vote: Int |
There was a problem hiding this comment.
This should ideally be an enum so we don't have to clamp it, but I guess that would mean duplicating the type and creating translate functions, which sounds tedious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
votefield to theFingerprintSubmissioninput. This supercedes theunmatchfield, which is now deprecated. Ifvoteis positive, then the submission is treated as an ordinary submission. Ifvoteis negative, then the submission is treated as a report. Ifvoteis0, then it is treated as an unmatch operation. Ifvoteis omitted altogether, then it is assumed to be a normal submission, unlessunmatchis set to true, per existing behaviour.Adds
reportsfield to theFingerprinttype. This value is the number of users that have reported a fingerprint. Also adds auser_reportedfield which returns true if the current user reported the fingerprint. Scene fingerprints are now ordered bysubmissions - reports.The UI is changed to indicate how many reports a fingerprint has. The button to remove a user submission is shown in the appropriate place based on if the user submitted or reported the fingerprint.