Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configurable UI #15

Closed
StashAppDev opened this issue Feb 11, 2019 · 6 comments
Closed

User configurable UI #15

StashAppDev opened this issue Feb 11, 2019 · 6 comments
Labels
feature Pull requests that add a new feature
Projects

Comments

@StashAppDev
Copy link
Member

stashapp/StashServer#48

@StashAppDev StashAppDev changed the title [Feature] User configurable UI User configurable UI Mar 24, 2019
@StashAppDev StashAppDev added the feature Pull requests that add a new feature label Mar 24, 2019
@echo6ix
Copy link
Contributor

echo6ix commented Aug 17, 2019

There's a few other projects that have implemented code injection for user configurable UIs, but the service that strikes me as the most obvious implementation of code injection is Squarespace.

The concept would be pretty simple, as described on the Squarespace site, "Use Code Injection to add HTML and scripts that enhance specific parts of your site.". Html, css, and javascript code added in this section is injected into the 'head' tag on the Stash pages.

A. There is a code injection option in the side panel

1

B. Within the code injection settings there are 7 different textarea tags (multi line text areas) for the users code injection, and 6 of these areas are related to each section of stash.

2

These areas are:

  1. Global. Used for code injection that will be common throughout Stash
  2. Scenes page
  3. Performers page
  4. Tags page
  5. Markers page
  6. Galleries page
  7. Studios page

C. Finally, at the bottom of the section would be a save button.

@echo6ix
Copy link
Contributor

echo6ix commented Aug 17, 2019

One more thing. Code injection could be a PITA when troubleshooting or reporting possible bugs. As a dev or user you'd want to troubleshoot or report a bug using vanilla Stash without any user code affecting operation. Therefore to save a lot of trouble I would suggest an option in the Code Injection settings to enable and disable code injection on the fly while preserving the user's custom code but disabling code injection.

@Leopere
Copy link
Collaborator

Leopere commented Nov 13, 2019

If we have a self-reporting thing https://github.com/google/go-github/blob/master/github/issues.go we can have the issues mention that the user has their own CSS/JS right in the top and that modified Stash Instances "void the warranty"

@Leopere
Copy link
Collaborator

Leopere commented Nov 13, 2019

Linking #197 as it would be beneficial for allowing features like this where it could "void the warranty."

@Leopere Leopere added this to To do in Wants via automation Nov 13, 2019
@Leopere
Copy link
Collaborator

Leopere commented Feb 13, 2020

I imagine that this is complete now that we have a CSS input box but if anyone disagrees they can re-open this and are encouraged to.

@Leopere Leopere closed this as completed Feb 13, 2020
Wants automation moved this from To do to Done Feb 13, 2020
@yoshnopa
Copy link
Contributor

It's been a while, but I'd like to ask for a little expansion of customizability. One can design great pages with a custom css, but the customization possibilities would be endless if there would be an option to support javascript as well. This would mean that the aforementioned Issue reporting template should be made aware of the dangers of custom javascript, but in general one can implement changes to the UI in any fashion this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
No open projects
Wants
  
Done
Development

No branches or pull requests

4 participants