Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Before navigating to the next image, delay navigation until additional scroll detected #2535

Closed
ALonelyJuicebox opened this issue Apr 27, 2022 · 1 comment · Fixed by #2544
Labels
bounty This issue has a bounty on it in the OpenCollective feature request

Comments

@ALonelyJuicebox
Copy link

ALonelyJuicebox commented Apr 27, 2022

Related to the fantastic PR by WithoutPants where mouse scrolling can be used to progress to the next image in the lightbox when the bottom of the page is reached. #2403

This is well implemented and a great addition! I should have provided this feedback during the dev testing of this PR.

When zoomed in a bit to an image, as you're navigating to the bottom of the image, it may not be obvious when the bottom of the page has been reached. The problem is, this can result in accidental navigation to the next image.

As a solution, when the bottom of the page is reached, prevent the user from scrolling down further (giving user feedback that the bottom of the image has been reached) THEN progress to the next image after receiving <x> additional scroll down events from the user (indicating there's user intent to move on to the next image)

Not sure what <x> should be or if it should be user configurable but some sort of delay on when progression happens would be nice to see. 🙂

This should be specifically for when there is room for the image to scroll (I don't think this makes sense for instances when the whole image is viewable).

Thanks! 🙏🏾

@WithoutPants WithoutPants added this to the Version 0.15.0 milestone Apr 29, 2022
@WithoutPants WithoutPants added the bounty This issue has a bounty on it in the OpenCollective label May 1, 2022
@WithoutPants
Copy link
Collaborator

$50 bounty added (29-Apr-2022)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty This issue has a bounty on it in the OpenCollective feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants