Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User forms (login/register/reset_password) should have specific errors bag containers instead of sharing the default one #1139

Open
chatelardfrancois opened this issue Feb 29, 2024 · 2 comments

Comments

@chatelardfrancois
Copy link

chatelardfrancois commented Feb 29, 2024

Context :
I have been asked to add login/register and reset_password form via popups so every form are rendered on the same html pages

Problem :
When a form encounters errors after submission, i have to repopen the correct popup (because page reloaded), this is why i check for errors but as every form share the same error bag ('default') i am not able to know wich form the error come from.

A specific container name for each form instead of using the default one could solve this problem

@chatelardfrancois chatelardfrancois changed the title User forms (login/register/reset_password) should have specific errors viewbag containers instead of sharing the default one User forms (login/register/reset_password) should have specific errors bag containers instead of sharing the default one Feb 29, 2024
@chatelardfrancois
Copy link
Author

Seems to be already the case for the user register form
image
Could be great to also have user.login and user.reset_password instead of "default" for those forms

@ryanmitchell
Copy link

This is already included as part of statamic/cms#8924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants