Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Value instance type error when merging non-existent seo data #246

Merged
merged 1 commit into from Dec 13, 2022

Conversation

jesseleite
Copy link
Member

Fix Value instance type error (see #245 (comment)), when merging non-existent entry seo data.

Fixes #245.

@what-the-diff
Copy link

what-the-diff bot commented Dec 13, 2022

  • The diff is changing the way that augmentedValue() works.
  • It's removing a call to value(), which was previously being called on an object returned by augmentedValue().
  • This change will affect all code in this project that calls $content->augmentedValue('seo'). In particular, it may cause errors if any of those places were expecting the return value from augmentedValue() to be an array instead of an object (which would have been true before).
  • I'm not sure what other effects this might have because I don't know how else or where else '$content' gets used throughout the rest of the application and whether there are any assumptions about its type elsewhere in our codebase; however, since we're using PHP 7 now, we should probably just remove these types altogether so they can be inferred automatically at runtime anyway...

@jesseleite jesseleite merged commit b590292 into master Dec 13, 2022
@jesseleite jesseleite deleted the fix/seo-value-array-type-error branch December 13, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value instance type error when merging non-existent seo data
1 participant