Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to include custom pages in sitemap #50

Open
wanze opened this issue Nov 26, 2018 · 4 comments
Open

Ability to include custom pages in sitemap #50

wanze opened this issue Nov 26, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@wanze
Copy link

wanze commented Nov 26, 2018

Problem/Motivation
SeoPro currently includes pages, entries and terms in the sitemap. This does not include routes directly rendering a template.

Proposed solution
Throw an event in Sitemap::pages() allowing modules to alter pages rendered in the sitemap. This event could be used to add, modify or remove pages.

I will submit a pull request if you think the proposed solution makes sense. :)

@jackmcdade jackmcdade added the enhancement New feature or request label Jun 27, 2019
@jesseleite jesseleite changed the title FR: Ability to include custom pages in sitemap Ability to include custom pages in sitemap Sep 15, 2020
@jesseleite jesseleite added bug Something isn't working and removed enhancement New feature or request labels Sep 15, 2020
@jesseleite
Copy link
Member

Whoops, wrong issue number... re-opening!

@jesseleite jesseleite reopened this Sep 15, 2020
@jesseleite jesseleite added enhancement New feature or request and removed bug Something isn't working labels Sep 15, 2020
@jesseleite
Copy link
Member

Love this idea, but I might prefer a urls array in the config/statamic/seo-pro.php config, similar to how our SSG handles custom urls. We'll revisit this one for sure 👍

@wanze
Copy link
Author

wanze commented Sep 19, 2020

Adding urls via config sounds like a nice addition. 👍 I still think that an additional event would be good to have, if you need to create dynamic sitemap entries based on data coming from an API. For example, we had a project where we displayed product detail pages from Shopify products in Statamic with a single route. As a developer, I would like to have the possibility to dynamically extend the sitemap :)

@jesseleite
Copy link
Member

Just thinking on this more with a user... Maybe also a closure based setter, or maybe even a hook (since Jason recently added hooks) to programatically add pages to sitemap in a service provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants