Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding error message to differentialTest when all models fail to converge #151

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

svteichman
Copy link
Collaborator

which passes the user an error message from one run of bbdml. Additionally updating the setup-r version from v1 to v2 for github actions and test coverage checks.

@svteichman svteichman assigned svteichman and unassigned svteichman Oct 4, 2023
@svteichman
Copy link
Collaborator Author

svteichman commented Oct 4, 2023

@MariaAVC I'm not able to assign this pull request directly for you to review, but are you able to self-assign? You may need certain permissions (perhaps to be a maintainer) to review and merge - if so let me know!

@MariaAVC
Copy link
Contributor

MariaAVC commented Oct 6, 2023

@svteichman It seems I do not have the write access to do a merge pull request.

@svteichman
Copy link
Collaborator Author

@adw96 could you give @MariaAVC permissions to do a pull request review please?

@adw96
Copy link
Collaborator

adw96 commented Oct 6, 2023

@svteichman 🙏
@MariaAVC did that work?

@MariaAVC
Copy link
Contributor

MariaAVC commented Oct 6, 2023

@adw96 Yes, it seems it worked! 👍

@MariaAVC MariaAVC merged commit 0cf8707 into statdivlab:master Oct 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants