Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version parameter from descrip()? #33

Closed
taylorokonek opened this issue Jul 26, 2021 · 2 comments
Closed

remove version parameter from descrip()? #33

taylorokonek opened this issue Jul 26, 2021 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@taylorokonek
Copy link
Collaborator

Currently if you specify version = TRUE in descrip(), the function will return "20160730" and nothing else. I'd imagine we either want to to return a date that's a bit closer to today, or just remove this parameter entirely. Personally, I'm in favor of removing it entirely. Any objections or other thoughts?

@taylorokonek taylorokonek added the question Further information is requested label Jul 26, 2021
@taylorokonek taylorokonek self-assigned this Jul 26, 2021
@bdwilliamson
Copy link
Collaborator

bdwilliamson commented Jul 26, 2021

I'm also in favor of removing it entirely (and removing the parameter across the package, because it exists in multiple functions).

Something we could consider is adding a print message when the package gets loaded that says something about the version and/or the package creation date. For example of just printing the version and package title, see here; for example of including the date as well, see here. Personally, I don't like the "package created on X date" message as much but could see it being nice if we have to change the package mid-quarter?

@taylorokonek
Copy link
Collaborator Author

New issue created to remove version parameter and change version info when package is loaded (#45)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants