Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'data' #32

Closed
NiloCK opened this issue Jun 24, 2021 · 0 comments
Closed

Rename 'data' #32

NiloCK opened this issue Jun 24, 2021 · 0 comments

Comments

@NiloCK
Copy link
Contributor

NiloCK commented Jun 24, 2021 •
edited
Loading

The exit format is a data structure whose "top priority" members (ie, the data) are the destination, asset, and amount. A data structure with a field called data seems to be saying something too generic.

In our case, data is less descriptive than either of:

  • metadata (data about other data)
  • decorator (a wrapper of other functionality which adds new behaviour)
NiloCK pushed a commit that referenced this issue Jun 24, 2021
#32 rename data field
4be74b6 
per linked issue, `metadata` is more descriptive
@NiloCK NiloCK mentioned this issue Jun 24, 2021
Merged
@NiloCK NiloCK closed this as completed in bebb92d Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiloCK