Some tweaks to PR 69 #70
Conversation
wraps metadata with a token type enum
| // * an allocations array | ||
| struct SingleAssetExit { | ||
| address asset; | ||
| bytes metadata; | ||
| TokenMetadata tokenMetadata; |
There was a problem hiding this comment.
Note: this is a breaking change. We could maintain backwards compatibility by encoding TokenMetadata into bytes. This would cost some more gas.
There was a problem hiding this comment.
This is much cleaner and more gas efficient for sure. It is just if a breaking change is viable at this stage. Maybe better to do it sooner rather than later?
There was a problem hiding this comment.
@willemolding we are comfortable with a breaking change.
TODO: We will want to handle it by increasing the first nonzero portion of the package semver which should prevent the breaking change reaching downstream packages until they explicitly upgrade.
If you like this approach, why not merge this into your PR, and then we can get a final review on #69?
| Allocation[] allocations; | ||
| } | ||
|
|
||
| struct TokenMetadata { |
There was a problem hiding this comment.
Is AssetMetadata better?
There was a problem hiding this comment.
Yeah I think that is more general
No description provided.