Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kernel from runme.yaml and add explicit docker support #582

Merged
merged 5 commits into from
May 23, 2024
Merged

Remove kernel from runme.yaml and add explicit docker support #582

merged 5 commits into from
May 23, 2024

Conversation

adambabik
Copy link
Collaborator

@adambabik adambabik commented May 21, 2024 •
edited
Loading

This change removes complicated kernels and introduces an explicit support for Docker:

docker:
  enabled: true
  image: runme-runtime:latest
  build:
    context: ./experimental/docker
    dockerfile: Dockerfile

Running code blocks in Docker is still not fully implemented.

@adambabik adambabik force-pushed the adamb/runme-yaml-remove-kernel branch from dbf7d3b to 0abd58f Compare May 21, 2024 20:45
@adambabik adambabik force-pushed the adamb/runme-yaml-remove-kernel branch from 0abd58f to 6eaeb1e Compare May 21, 2024 20:51
sourishkrout
sourishkrout approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sourishkrout sourishkrout merged commit 3fb1bd4 into main May 23, 2024
6 checks passed
@sourishkrout sourishkrout deleted the adamb/runme-yaml-remove-kernel branch May 23, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adambabik @sourishkrout