Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Naive shim attempt for event-target-shim to enable functionality on react-native #7

Closed
wants to merge 1 commit into from
Closed

[DRAFT] Naive shim attempt for event-target-shim to enable functionality on react-native #7

wants to merge 1 commit into from

Conversation

technoplato
Copy link

Not sure exactly where this should go so I put it in both files that depend on PartySocket

Attempting to address #6

@technoplato
Naive shim attempt for event-target-shim
d6fa53e 
Not sure exactly where this should go so I put it in both files that depend on PartSocket
@technoplato technoplato marked this pull request as draft October 17, 2023 11:49
@technoplato
Copy link
Author

Closing with: technoplato/StatelySkyShimDemoReactNative2#1 (comment)

@Andarist Thanks for your quick action on this.

Since what is currently in main now works, can we go with it for now? I think I tried what you're suggesting now already and it did not work.

Here is the commit where it's working: technoplato/StatelySkyShimDemoReactNative2@243b0ab#r130225625

@technoplato technoplato deleted the mlustig/shim-for-react-native branch October 17, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@technoplato @Andarist