Specify how to get the scxml files for the tests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matEhickey
changed the title
|
Hmm, there will be a lot more test files from that module, so what would be a better way for us to use those? |
|
Ha ok, So maybe just precising in the testing section of the readme to npm install the corresponding package ? That was enough for me
|
matEhickey
force-pushed
the
matehickey/fix_scxml_tests
branch
from
ea56754
to
4f4ac0c
Compare
matEhickey
force-pushed
the
matehickey/fix_scxml_tests
branch
from
4f4ac0c
to
b44b334
Compare
matEhickey
changed the title
|
Here it is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There were problems to execute the tests as node_modules files were gitignored, so I just extracted them.
I allowed myself to remove the package-lock as I don't think it's needed anymore
I cleaned a useless argument in a machine test (PR incoming covering that, you can take a look at my progress here (matEhickey#1 ))
:)