Merge pull request #278 from statelyai/farskid/sta-630-show-the-compl…

…ete-url-in-the-embed-code Farskid/sta 630 Show the complete url in the embed code
statelyai · Sep 27, 2021 · cd128a1 · cd128a1
2 parents 7588433 + 8e0b2de
commit cd128a1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/EmbedPreview.tsx b/src/EmbedPreview.tsx
@@ -209,6 +209,7 @@ const EmbedPreviewContent: React.FC = () => {
       makeEmbedUrlAndCode: assign((ctx) => {
         const url = makeEmbedUrl(
           router.query.sourceFileId as string,
+          window.location.origin,
           ctx.params,
         );
 
@@ -221,6 +222,7 @@ const EmbedPreviewContent: React.FC = () => {
       makePreviewUrl: assign((ctx) => {
         const url = makeEmbedUrl(
           router.query.sourceFileId as string,
+          window.location.origin,
           ctx.params,
         );
         return {

diff --git a/src/__tests__/utils.test.ts b/src/__tests__/utils.test.ts
@@ -5,7 +5,7 @@ describe('utils', () => {
   describe('makeEmbedUrl', () => {
     it('makes a valid url with booleans turned to numbers', () => {
       expect(
-        utils.makeEmbedUrl('source_id', {
+        utils.makeEmbedUrl('source_id', 'https://stately.ai', {
           mode: EmbedMode.Panels,
           panel: EmbedPanel.Events,
           readOnly: false,
@@ -15,7 +15,7 @@ describe('utils', () => {
           controls: true,
         }),
       ).toBe(
-        '/viz/embed/source_id?mode=panels&panel=events&readOnly=0&pan=0&zoom=1&showOriginalLink=0&controls=1',
+        'https://stately.ai/viz/embed/source_id?mode=panels&panel=events&readOnly=0&pan=0&zoom=1&showOriginalLink=0&controls=1',
       );
     });
   });

diff --git a/src/utils.ts b/src/utils.ts
@@ -319,7 +319,7 @@ export function paramsToRecord(
   );
 }
 
-export function makeEmbedUrl(id: string, params: ParsedEmbed) {
+export function makeEmbedUrl(id: string, baseUrl: string, params: ParsedEmbed) {
   const paramsWithNumberValues = Object.entries(params).reduce(
     (result, current) => {
       return {
@@ -332,7 +332,7 @@ export function makeEmbedUrl(id: string, params: ParsedEmbed) {
     {},
   );
   const query = new URLSearchParams(paramsWithNumberValues as any);
-  return `/viz/embed/${id}?${query.toString()}`;
+  return `${baseUrl}/viz/embed/${id}?${query.toString()}`;
 }
 // unsure if this should include button-like input elements
 export const hasRoleButton = (el: HTMLElement): boolean => {