-
Notifications
You must be signed in to change notification settings - Fork 100
Conversation
🦋 Changeset detectedLatest commit: 01bb94b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/statelyai/xstate-viz/FpL6zes6kgduz3qGSBpDjq1HoF4w |
@@ -68,38 +68,6 @@ export const simulationMachine = simModel.createMachine( | |||
? 'inspecting' | |||
: 'visualizing', | |||
entry: assign({ notifRef: () => spawn(notifMachine) }), | |||
invoke: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is this for visualisations done inside the app during development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does spawning/invoking machines still work? I think that's what this was for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it didn't! Have now made it so it only reports from interpreters that have a parent - i.e. ONLY child machines/invocations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this part but probably @Andarist does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix, the logic makes sense! Just added a note for us in the future
events: (ctx, e) => { | ||
return produce(ctx.events, (draft) => { | ||
draft.push({ | ||
...e.state._event, | ||
timestamp: Date.now(), | ||
sessionId: e.sessionId, | ||
}); | ||
}), | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be an unnecessary change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it's only formatting though
Co-authored-by: David Khourshid <davidkpiano@gmail.com>
No description provided.