-
Notifications
You must be signed in to change notification settings - Fork 100
Remove compaction on root node. Fixes #279 #334
Conversation
🦋 Changeset detectedLatest commit: 076a5f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/statelyai/xstate-viz/BD8rbGi7LDKuzJAurbLgpATEx7Yt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u add a simple test that would just verify that the machine gets visualized correctly?
Done, please re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK from mobile :) out of curiosity - what does compaction usually do? Was this misconfigured on our end or can this be classified as Elk’s bug?
It's an ELK issue, I believe. The replies here suggest that it has to do with compaction: kieler/elkjs#98 |
This PR removes compaction on the root node, which was causing ELK to fail with self-transitions on the machine.