Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Remove compaction on root node. Fixes #279 #334

Merged
merged 3 commits into from
Jan 9, 2022
Merged

Conversation

davidkpiano
Copy link
Member

This PR removes compaction on the root node, which was causing ELK to fail with self-transitions on the machine.

CleanShot 2022-01-09 at 06 31 09@2x

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2022

🦋 Changeset detected

Latest commit: 076a5f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate-viz-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/BD8rbGi7LDKuzJAurbLgpATEx7Yt
✅ Preview: https://xstate-viz-git-davidkpiano-279-statelyai.vercel.app

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u add a simple test that would just verify that the machine gets visualized correctly?

@davidkpiano
Copy link
Member Author

Can u add a simple test that would just verify that the machine gets visualized correctly?

Done, please re-review

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK from mobile :) out of curiosity - what does compaction usually do? Was this misconfigured on our end or can this be classified as Elk’s bug?

@davidkpiano
Copy link
Member Author

Looks OK from mobile :) out of curiosity - what does compaction usually do? Was this misconfigured on our end or can this be classified as Elk’s bug?

It's an ELK issue, I believe. The replies here suggest that it has to do with compaction: kieler/elkjs#98

@davidkpiano davidkpiano merged commit 4ce3795 into dev Jan 9, 2022
@davidkpiano davidkpiano deleted the davidkpiano/279 branch January 9, 2022 15:22
@github-actions github-actions bot mentioned this pull request Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants