Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Fixed panning/dragging interations (the ones that include pressing pointer down) in FireFox #343

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Feb 1, 2022

#342

FF is using 0 as pointerId for the primary pointer so naturally this didn't pass the truthiness check here. Other browsers worked as they are using 1.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

🦋 Changeset detected

Latest commit: b01d433

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate-viz-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/J3ZkuFtVTwVgrMsb6qMXX5iNiHr7
✅ Preview: https://xstate-viz-git-andarist-fix-342-statelyai.vercel.app

Copy link
Member

@davidkpiano davidkpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've seen this fix before... deja vu!

@Andarist Andarist merged commit 632f950 into dev Feb 1, 2022
@Andarist Andarist deleted the andarist/fix-342 branch February 1, 2022 14:08
@Andarist
Copy link
Member Author

Andarist commented Feb 1, 2022

Yep, my hard-earned experience allowed me to fix this quickly :trollface:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants