Fixed an issue with states created using machine.getInitialState no…

…t being "resolved" in full (#3023)
statelyai · Feb 7, 2022 · 642e9f5 · 642e9f5
1 parent 8d375ac
commit 642e9f5
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 7 deletions.
diff --git a/.changeset/nervous-crabs-cry.md b/.changeset/nervous-crabs-cry.md
@@ -0,0 +1,5 @@
+---
+'xstate': patch
+---
+
+Fixed an issue with states created using `machine.getInitialState` not being "resolved" in full. This could cause some things, such as `after` transitions, not being executed correctly after starting an interpreter using such state.
diff --git a/packages/core/src/StateNode.ts b/packages/core/src/StateNode.ts
@@ -1625,6 +1625,7 @@ class StateNode<
     stateValue: StateValue,
     context?: TContext
   ): State<TContext, TEvent, TStateSchema, TTypestate, TResolvedTypesMeta> {
+    this._init(); // TODO: this should be in the constructor (see note in constructor)
     const configuration = this.getStateNodes(stateValue);
 
     return this.resolveTransition(
@@ -1653,7 +1654,6 @@ class StateNode<
     TTypestate,
     TResolvedTypesMeta
   > {
-    this._init(); // TODO: this should be in the constructor (see note in constructor)
     const { initialStateValue } = this;
 
     if (!initialStateValue) {

diff --git a/packages/core/test/after.test.ts b/packages/core/test/after.test.ts
@@ -1,8 +1,8 @@
-import { Machine, interpret } from '../src';
+import { createMachine, interpret } from '../src';
 import { after, cancel, send, actionTypes } from '../src/actions';
 import { toSCXMLEvent } from '../src/utils';
 
-const lightMachine = Machine({
+const lightMachine = createMachine({
   id: 'light',
   initial: 'green',
   context: {
@@ -53,7 +53,7 @@ describe('delayed transitions', () => {
   });
 
   it('should be able to transition with delay from nested initial state', (done) => {
-    const machine = Machine({
+    const machine = createMachine({
       initial: 'nested',
       states: {
         nested: {
@@ -82,7 +82,7 @@ describe('delayed transitions', () => {
 
   it('parent state should enter child state without re-entering self (relative target)', (done) => {
     const actual: string[] = [];
-    const machine = Machine({
+    const machine = createMachine({
       initial: 'one',
       states: {
         one: {
@@ -119,7 +119,7 @@ describe('delayed transitions', () => {
   it('should defer a single send event for a delayed transition with multiple conditions (#886)', () => {
     type Events = { type: 'FOO' };
 
-    const machine = Machine<{}, Events>({
+    const machine = createMachine<{}, Events>({
       initial: 'X',
       states: {
         X: {
@@ -146,11 +146,35 @@ describe('delayed transitions', () => {
     expect(machine.initialState.actions.length).toBe(1);
   });
 
+  it('should execute an after transition after starting from a state resolved using `machine.getInitialState`', (done) => {
+    const machine = createMachine({
+      id: 'machine',
+      initial: 'a',
+      states: {
+        a: {},
+
+        withAfter: {
+          after: {
+            1: { target: 'done' }
+          }
+        },
+
+        done: {
+          type: 'final'
+        }
+      }
+    });
+
+    interpret(machine)
+      .onDone(() => done())
+      .start(machine.getInitialState('withAfter'));
+  });
+
   describe('delay expressions', () => {
     type Events =
       | { type: 'ACTIVATE'; delay: number }
       | { type: 'NOEXPR'; delay: number };
-    const delayExprMachine = Machine<{ delay: number }, Events>(
+    const delayExprMachine = createMachine<{ delay: number }, Events>(
       {
         id: 'delayExpr',
         initial: 'inactive',