Fixed an issue with tags not being set correctly after sending an eve…

…nt to a machine that didn't result in selecting any transitions
statelyai · May 4, 2021 · 64ab115 · 64ab115
1 parent c1cca81
commit 64ab115
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/.changeset/soft-cats-trade.md b/.changeset/soft-cats-trade.md
@@ -0,0 +1,5 @@
+---
+'xstate': patch
+---
+
+Fixed an issue with tags not being set correctly after sending an event to a machine that didn't result in selecting any transitions.
diff --git a/packages/core/src/StateNode.ts b/packages/core/src/StateNode.ts
@@ -1263,7 +1263,8 @@ class StateNode<
       configuration: resolvedConfiguration,
       transitions: stateTransition.transitions,
       children,
-      done: isDone
+      done: isDone,
+      tags: currentState?.tags
     });
 
     const didUpdateContext = currentContext !== updatedContext;

diff --git a/packages/core/test/tags.test.ts b/packages/core/test/tags.test.ts
@@ -91,6 +91,22 @@ describe('tags', () => {
     expect(state.tags).toEqual(new Set(['yes', 'no']));
   });
 
+  it('sets tags correctly after not selecting any transition', () => {
+    const machine = createMachine({
+      initial: 'a',
+      states: {
+        a: {
+          tags: 'myTag'
+        }
+      }
+    });
+
+    const state = machine.transition(machine.initialState, {
+      type: 'UNMATCHED'
+    });
+    expect(state.hasTag('myTag')).toBeTruthy();
+  });
+
   it('tags can be single (not array)', () => {
     const machine = createMachine({
       initial: 'green',