Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen types for SendAction. Fixes #570 #1069

Merged
merged 2 commits into from
Mar 14, 2020
Merged

Loosen types for SendAction. Fixes #570 #1069

merged 2 commits into from
Mar 14, 2020

Conversation

davidkpiano
Copy link
Member

This PR loosens the SendAction type in Actions to accept AnyEventObject, since the target of the send action might accept different types of events (and can't be easily determined compile-time)

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2020

🦋 Changeset is good to go

Latest commit: d5f622f

We got this.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d5f622f:

Sandbox Source
quizzical-albattani-xvtww Configuration
naughty-darkness-7zl69 Configuration

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Please just add the appropriate changeset and you can merge it in :)

@davidkpiano davidkpiano merged commit 3bc00a9 into master Mar 14, 2020
@davidkpiano davidkpiano deleted the davidkpiano/570 branch March 14, 2020 20:34
@github-actions github-actions bot mentioned this pull request Mar 14, 2020
@github-actions github-actions bot mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants