Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that prematurely spawned actors are also deferred. Fixes #1281 #1290

Merged
merged 7 commits into from
Jul 12, 2020

Conversation

davidkpiano
Copy link
Member

@davidkpiano davidkpiano commented Jul 8, 2020

This fixes #1281 by essentially adding .deferred to spawned actors, and making them behave like prematurely invoked actors would behave.

@davidkpiano davidkpiano requested a review from Andarist July 8, 2020 00:14
@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2020

🦋 Changeset is good to go

Latest commit: a7da145

We got this.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7da145:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration
reverent-yonath-1pwjl Issue #1281

@@ -1,6 +1,6 @@
{
"name": "@xstate/react",
"version": "1.0.0-rc.3",
"version": "1.0.0-rc.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hasnt been published yet - I think it would be best to only bump versions when actually releasing them

sideways q: wasn't rc.5 merged into master? i see a 3 -> 6 bump here, which looks weird and maybe we've lost some git history along the way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was bumped out-of-band. Sorry about that.

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should land together with #1282 (once failing tests there get fixed) or the warning in question should get removed entirely.

@davidkpiano
Copy link
Member Author

This should land together with #1282 (once failing tests there get fixed) or the warning in question should get removed entirely.

Instead of #1282, I fixed the heuristics for "lazy entities" so that we won't get those warnings.

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might require some changeset for xstate - other than that LGTM

@davidkpiano davidkpiano merged commit 597cfdc into master Jul 12, 2020
@davidkpiano davidkpiano deleted the davidkpiano/1281 branch July 12, 2020 13:15
@github-actions github-actions bot mentioned this pull request Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with xstate/react@1.0.0-rc.5
2 participants