-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that prematurely spawned actors are also deferred. Fixes #1281 #1290
Conversation
🦋 Changeset is good to goLatest commit: a7da145 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7da145:
|
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@xstate/react", | |||
"version": "1.0.0-rc.3", | |||
"version": "1.0.0-rc.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hasnt been published yet - I think it would be best to only bump versions when actually releasing them
sideways q: wasn't rc.5
merged into master? i see a 3 -> 6 bump here, which looks weird and maybe we've lost some git history along the way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was bumped out-of-band. Sorry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should land together with #1282 (once failing tests there get fixed) or the warning in question should get removed entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might require some changeset for xstate
- other than that LGTM
This fixes #1281 by essentially adding
.deferred
to spawned actors, and making them behave like prematurely invoked actors would behave.