fix: use event generic in ServiceConfig type #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Ran into a typing problem when using
MachineConfig
. The following code does not compile in TypeScript with"strict": true
This is because
ServiceConfig
expects anInvokeCreator
that usesAnyEventObject
.In TypeScript's strict mode,
TestEvent
is not compatible withAnyEventObject
as all TestEvents are inferred as having apayload
property.This PR fixes the problem by having
ServiceConfig
(like the other types inMachineOptions
) use the supplied event generic.