Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Remove StateSchema #2191

Merged
merged 2 commits into from
May 12, 2021
Merged

[v5] Remove StateSchema #2191

merged 2 commits into from
May 12, 2021

Conversation

davidkpiano
Copy link
Member

This PR removes StateSchema from all types in v5. We'll figure out a better way to have strong typing of state keys, but this is the first step.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2021

🦋 Changeset detected

Latest commit: 0038c7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
xstate Major
@xstate/graph Major
@xstate/immer Major
@xstate/inspect Major
@xstate/react Major
@xstate/svelte Major
@xstate/test Major
@xstate/vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidkpiano davidkpiano changed the base branch from master to next May 12, 2021 12:56
@davidkpiano
Copy link
Member Author

@Andarist The only tests failing here are the ones around JSX, which I'm ignoring for now.

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing changeset it's all good and... hooray for the change 🥳

@davidkpiano davidkpiano merged commit 622b4ea into next May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants