Support globalThis
in getGlobal()
for better compatibility
#2819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalThis
is the actual ECMAScript standard for the global object, so this should be returned bygetGlobal()
when available. The existing code (taken from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis) is good as a replacement whenglobalThis
is not available, but when it is, we should return it directly! See a similar example in Ember.js.This fixes a real world issue I had when running
xstate
in a rather exotic environment (GraalVM running JS inside a Java server), which correctly supportsglobalThis
, but does not supportglobal
(which is node.js specific!) orself
.