-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Resolve state from a state config object #2892
Conversation
🦋 Changeset detectedLatest commit: ddd9c53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
packages/core/src/StateNode.ts
Outdated
): State<TContext, TEvent, TStateSchema, TTypestate> { | ||
const resolvedState = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a somewhat confusing name. I would call the resolvedState
what gets returning from this function but this is just an intermediate value. Maybe something like resolvedInput
/resolvedArg
would make more sense here?
Ready for re-review |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ddd9c53:
|
This PR makes it easier to restore state by allowing a state config object to be passed into
machine.resolveState(object)
: