Bring back the global type declaration for the Symbol.observable to fix consuming projects that do not use skipLibCheck
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix consuming projects that do not use `skipLibCheck`
🦋 Changeset detectedLatest commit: 809e353 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
davidkpiano
approved these changes
Jan 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2950
I rly dislike that we are affecting a global thing here - stuff like that causes me harm in the past on several occasions. The risk here is somewhat low but I still dislike the sole notion of doing this 😉
This Symbol is just a „pseudo” standard - it was part of the ES Observable proposal but that never moved far in the standards process. I sympathize with Evan You here: vuejs/core#968 (comment)
A funny thing is that… Rx Observables don’t include this property at the type level and they dont pass their own
InteropObservabletype-level „check” (although I’ve deduced this from their code and im not sure if I’ve verified this in an actual project, I was playing around with that yesterday and would have to recheck that to be absolutely sure about this)