improve exporting of 'actions' #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 3230742 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
|
Great contribution; thanks! Can you add a changeset? This would be a minor change, I believe (cc. @Andarist) |
davidkpiano
reviewed
Jan 26, 2022
Co-authored-by: David Khourshid <davidkpiano@gmail.com>
|
@davidkpiano @Andarist was there anything else for this PR? Otherwise bump for visibility and hopefully merge 馃 Also great work on the typegen, can't wait to integrate it to our own codebase! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello xstate team 馃憢
I asked a question some time ago if there are any functions that can retrieve the event names for done/error of services but the answer:
DIdn't seem to work. I realised later that some of exports from the
actions.tsfile aren't actually exported properly. Especially the ones we're after e.g.doneInvokeanderror.So this the change I'm making to improve how actions are exported. I don't think I've broken any exports but now everything that's exported from
actions.tsis now exposed. Let me know if this not the right fix and I can change this to only export the ones we need and were assumed to be exported.Cheers!
Satya