-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue with a reference to @types/node
being inserted into XState's compiled output
#3012
Conversation
🦋 Changeset detectedLatest commit: c5dfe84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
@@ -140,7 +143,7 @@ export class Interpreter< | |||
clearTimeout: (id) => { | |||
return clearTimeout(id); | |||
} | |||
}, | |||
} as Clock, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, tsc
has started to infer the setTimeout
's return type of this default clock to be of type NodeJS.Timeout
. That in turn has caused it to include /// <reference types="node" />
at the top of the file and that has created the reported issue.
A couple of type errors, but after that LGTM |
…XState's compiled output
c34a940
to
c5dfe84
Compare
@davidkpiano i've removed that |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c5dfe84:
|
fixes #3010